Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

improve z-ordering of annotations #988

Closed
incanus opened this issue Mar 12, 2015 · 6 comments
Closed

improve z-ordering of annotations #988

incanus opened this issue Mar 12, 2015 · 6 comments
Milestone
iOS Beta 2

Comments

@incanus
Copy link
Contributor

incanus commented Mar 12, 2015

Related to mapbox/mapbox-gl-js#470, we want annotations to sort in the z direction from top to bottom of screen, like Apple's.

Not like this

@jfirebaugh Can you take an initial look at how complicated this will be?
@incanus incanus added this to the iOS Beta 1 milestone Mar 12, 2015
This was referenced Mar 12, 2015
Closed
Closed
@incanus incanus changed the title expected z-ordering of annotaions expected z-ordering of annotations Mar 12, 2015
@jfirebaugh jfirebaugh modified the milestones: iOS Beta 2, iOS Beta 1 Mar 13, 2015
@jfirebaugh
Copy link
Contributor

Not critical for Beta 1.

@incanus incanus mentioned this issue Mar 13, 2015
Closed
@incanus
Copy link
Contributor Author

incanus commented Mar 16, 2015

Here's the MapKit-like default algorithm used in our iOS SDK:

https://github.com/mapbox/mapbox-ios-sdk/blob/dd26736adb6c2769accb99bd687509a0119780d6/MapView/Map/RMMapView.m#L3119-L3181

@incanus
Copy link
Contributor Author

incanus commented Mar 22, 2015

Hitting this for b2, but this is how things look in the shipping style:

ios simulator screen shot mar 21 2015 5 27 24 pm

@incanus incanus changed the title expected z-ordering of annotations improve z-ordering of annotations Mar 22, 2015
@ansis ansis mentioned this issue Apr 7, 2015
Closed
@ansis
Copy link
Contributor

ansis commented Apr 7, 2015

This will be easy to implement once we can redo placement on rotation: mapbox/mapbox-gl-js@5bf094f

Spec issue here: mapbox/mapbox-gl-style-spec#274

@ansis
Copy link
Contributor

ansis commented Apr 30, 2015

This is implemented in -js mapbox/mapbox-gl-js#1184
We should port the same approach to -native. It should be ported to the new-labelling branch.

@jfirebaugh jfirebaugh removed their assignment May 14, 2015
@incanus incanus mentioned this issue May 26, 2015
Closed
7 tasks
ansis added a commit that referenced this issue May 29, 2015
@ansis
sort overlapping symbols in the y direction
de3fd89 
fixes #333
fixes #988

-js: 6514de77be2ff3df4267785f42f5e53c63233cac
@incanus
Copy link
Contributor Author

incanus commented Jun 1, 2015

@ansis label porting work in #1666 hits this.

@ansis ansis mentioned this issue Jun 2, 2015
Closed
@ansis ansis closed this as completed in 36212ea Jun 3, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
iOS Beta 2
Development

No branches or pull requests
3 participants
@incanus @jfirebaugh @ansis