Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] Reorganize dependencies #10268

Merged
merged 1 commit into from
Oct 26, 2017
Merged

[android] Reorganize dependencies #10268

merged 1 commit into from
Oct 26, 2017

Conversation

zugaldia
Copy link
Member

This PR moves some dependencies out of the SDK that are only necessary for the Test App.

@zugaldia zugaldia requested a review from tobrun October 24, 2017 17:54
@zugaldia zugaldia added this to the android-v5.2.0 milestone Oct 24, 2017
@tobrun
Copy link
Member

tobrun commented Oct 24, 2017

@zugaldia lint is complaining about incompatible gradle version for the SDK. This is because the lost dependency and telem are bringing in a couple of support libs. I optimised the dependencies to not include redundant dependencies. eg. fragment + support annoation code is pulled in with supportv7.

@zugaldia
Copy link
Member Author

Thanks @tobrun for the pass. Lint is still complaining, I need to figure out what the actual error is:

image

@tobrun
Copy link
Member

tobrun commented Oct 25, 2017

@zugaldia:

All com.android.support libraries must use the exact same version specification (mixing versions can lead to runtime crashes). Found versions 25.4.0, 25.1.0. Examples include com.android.support:support-compat:25.4.0 and com.android.support:animated-vector-drawable:25.1.0

we need to look into excluding modules from dependencies that rely on 25.1.0

@zugaldia
Copy link
Member Author

Thanks @tobrun for the extra push, looks like we're now good to go (pending CI changes from #10289).

@zugaldia zugaldia merged commit bd06e2f into release-agua Oct 26, 2017
@tobrun tobrun deleted the agua-deps branch October 26, 2017 17:02
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 26, 2017
20 tasks
@tobrun tobrun mentioned this pull request Nov 3, 2017
21 tasks
@tobrun tobrun mentioned this pull request Nov 7, 2017
This was referenced Nov 14, 2017
@tobrun tobrun mentioned this pull request Feb 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants