This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fix broken android unit tests, update test make target to SDK #10387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
commented
Nov 6, 2017
| @@ -74,15 +74,6 @@ public void center() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void emptySpan() { | |||
There was a problem hiding this comment.
Not valid anymore with #9955
Good catch. Is this still a WIP? I don't see any changes to the |
tobrun
force-pushed
the
tvn-fix-unit-tests
branch
from
82a65fa
to
839e0a0
Compare
|
yes forgot to push, in 839e0a0 |
zugaldia
approved these changes
Nov 6, 2017
This was referenced Nov 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The java unit tests were broken, CI didn't notice as we were trying to build the unit tests from the testapp while they are now found in the SDK. This PR updates the make target and fixes the broken tests.