This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
avoid adding duplicate points to bounds #9955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
changed the title
Guardiola31337
suggested changes
Sep 11, 2017
| @@ -450,7 +450,9 @@ public LatLngBounds build() { | |||
| */ | |||
| public Builder includes(List<LatLng> latLngs) { | |||
| for (LatLng point : latLngs) { | |||
| latLngList.add(point); | |||
| if (!latLngList.contains(point)) { | |||
There was a problem hiding this comment.
Could you extract this into a private method? The same exact piece of code is duplicated and could be simplified and used from both includes and include methods.
tobrun
force-pushed
the
9953-validate-if-point-was-contained
branch
from
eb9cd34
to
6f5b62c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9953, this PR validates if a point added to the LatLngBounds builder hasn't been added before. Atm a developer can create a bounds from one point by passing in the same point twice.