Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

setLatLng constrained documentation + expose LatLngZoom #11184

Merged
merged 1 commit into from
Feb 13, 2018

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Feb 13, 2018

Closes #10928

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Feb 13, 2018
@tobrun tobrun added this to the android-v6.0.0 milestone Feb 13, 2018
@tobrun tobrun self-assigned this Feb 13, 2018
@tobrun tobrun changed the title setLatLng constrained documentatio + expose LatLngZoom setLatLng constrained documentation + expose LatLngZoom Feb 13, 2018
@tobrun tobrun merged commit 734b420 into release-boba Feb 13, 2018
@tobrun tobrun deleted the 10928-latlng-zoom branch February 13, 2018 11:52
@tobrun tobrun mentioned this pull request Feb 13, 2018
23 tasks
*
* @param latLng Target location to change to
*/
public void setLatLngZoom(@NonNull LatLng latLng,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add this. It's already possible to set center and zoom simultaneously with moveCamera -- there's no need to add to what is already a sprawling camera API. If anything, we should be removing individual setters such as setLatLng and setZoom in favor of the unified moveCamera.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially implemented that api for having a more performant way of doing camera updates with Android SDK animators. After running benchmarks on both setups, the difference is neglectable:

screen shot 2018-02-14 at 07 34 32

thank you for flagging @jfirebaugh, I will work on removing the API.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobrun I'd be great to sync the removal of exposed setters with mapbox/mapbox-plugins-android#259 and #11170 as right now exposed setters are the only way to manipulate camera without a loss of tracking mode.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happening in #11201

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants