This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Remove obsolete camera api #11201
Merged
Remove obsolete camera api #11201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to CameraUpdateFactory api
LukasPaczos
reviewed
Feb 14, 2018
| /** | ||
| * Tests camera transformations that aren't part of our public API | ||
| */ | ||
| public class CameraInternalApiTest extends BaseActivityTest { |
There was a problem hiding this comment.
@tobrun Is there a chance that we can leave this camera test in place, just swapping for a different API?
There was a problem hiding this comment.
the tests found in that class were ignored due to being device specific, as long as we don't have #7221 in place. I didn't feel it was worth keeping them around.
LukasPaczos
approved these changes
Feb 20, 2018
LukasPaczos
added
the
SEMVER-MAJOR
This was referenced Mar 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the comment in #11184 (comment): this PR removes the obsolete MapboxMap camera api in favor of
MapboxMap#moveToapi. To support the same use-casesCameraUpdateFactory#bearingToandCameraUpdateFactory#tiltTowere added.cc @jfirebaugh