This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[build] Push binary size history to S3 #12538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
force-pushed
the
binary-size-history
branch
from
ce117ad
to
302240a
Compare
friedbunny
added
build
performance
jfirebaugh
force-pushed
the
binary-size-history
branch
from
302240a
to
15d9077
Compare
jfirebaugh
force-pushed
the
binary-size-history
branch
from
15d9077
to
81850a7
Compare
jfirebaugh
commented
Aug 2, 2018
platform/android/scripts/metrics.sh
Outdated
| @@ -11,3 +11,7 @@ scripts/check_binary_size.js "platform/android/MapboxGLAndroidSDK/build/intermed | |||
|
|
|||
| # Track overall library size | |||
| scripts/check_binary_size.js "platform/android/MapboxGLAndroidSDK/build/outputs/aar/MapboxGLAndroidSDK-release.aar" "Android AAR" | |||
|
|
|||
| if [[ $CIRCLE_BRANCH == binary-size-history ]]; then | |||
There was a problem hiding this comment.
binary-size-history is temporary, to confirm that it's working. I will switch to master before merging.
anandthakker
reviewed
Aug 6, 2018
| @@ -19,7 +19,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@octokit/rest": "^15.9.2", | |||
| "aws-sdk": "^2.3.5", | |||
| "aws-sdk": "^2.285.1", | |||
anandthakker
approved these changes
Aug 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12212.