This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Rename Raster => Texture #6571
Merged
Rename Raster => Texture #6571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kkaefer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @incanus, @jfirebaugh and @tmpsantos to be potential reviewers. |
tmpsantos
approved these changes
Oct 4, 2016
tmpsantos
reviewed
Oct 4, 2016
| } | ||
|
|
||
| std::array<uint16_t, 2> OffscreenTexture::getSize() const { | ||
| return raster.getSize(); | ||
| return texture ? texture->size : std::array<uint16_t, 2>{{ 0, 0 }}; |
There was a problem hiding this comment.
Puzzles me why clang finds this ambiguous.
There was a problem hiding this comment.
Yeah; seems that (*texture).size works. Maybe a bug in Clang 3.5?
kkaefer
force-pushed
the
6571-raster-to-texture
branch
from
afb8492
to
757bdf3
Compare
jfirebaugh
approved these changes
Oct 4, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently using Raster as the name for our texture wrapper object, but we should standardize on
Texture.