-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add support for node v6 #8884
Add support for node v6 #8884
Conversation
platform/node/bitrise.yml
Outdated
export PUBLISH=true | ||
make test-node | ||
./platform/node/scripts/after_success.sh | ||
- slack: *slack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure if this is the best way to add another version for bitrise to test.
@bsudekum looks like you are using |
The last todo is to figure out how to test and publish macos on node v6. Unfortunately bitrise does not support matrix builds like on travis. We have a few options here:
/cc @1ec5 |
Now that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, providing we a plan to eventually deprecate node v4 support, I think this is reasonable. There will have to be some window where we support both.
platform/node/bitrise.yml
Outdated
brew unlink node@4 | ||
brew link --overwrite node@6 --force | ||
make clean | ||
make test-node | ||
./platform/node/scripts/after_success.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after_success.sh
is what performs the publish, so it needs to be run after both the node@4 and node@6 builds or otherwise only the latter will get published. Suggest something like:
make test-node && ./platform/node/scripts/after_success.sh
.travis.yml
Outdated
@@ -133,6 +133,58 @@ matrix: | |||
after_failure: | |||
- aws s3 cp . s3://mapbox/mapbox-gl-native/render-tests/$TRAVIS_JOB_NUMBER --recursive --exclude "*" --include "*.trace" | |||
|
|||
# EGL - Node v6 - Clang 3.9 - Debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there's a compelling reason to test the Node v6 debug build independently from Node v4 debug and Node v6 release, we can probably omit this row from the matrix.
It's time to add support for node v6. I think this should be fairly straightforward quest:
/cc @tmpsantos @jfirebaugh @springmeyer