Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cocoapods Build From Source #118

Merged
merged 12 commits into from
Feb 22, 2021
Merged

Cocoapods Build From Source #118

merged 12 commits into from
Feb 22, 2021

Conversation

neelmistry94
Copy link
Contributor

@neelmistry94 neelmistry94 commented Feb 18, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-ios changelog: <changelog>Consumption of MapboxMaps via Cocoapods will now build from source</changelog>.

Summary of changes

Updates the podspec to use a build from source approach. It also defaulting to updating source builds for MME and Turf.

In order to test

  1. Create a new Xcode project
  2. In the command line, navigate to the root of your new tester app, and then type pod init. This will create a Podfile for you.
  3. Open your Podfile, and under your app target, add this line pod 'MapboxMaps', :git => 'https://github.com/mapbox/mapbox-maps-ios.git', :branch => 'nm/pods_build_from_source'
  4. In the command line, type pod install --repo-update to install this as a dependency
  5. Open your project.xcworkspace and then try building a map

MapboxMaps.podspec Outdated Show resolved Hide resolved
MapboxMaps.podspec Outdated Show resolved Hide resolved
MapboxMaps.podspec Outdated Show resolved Hide resolved
MapboxMaps.podspec Outdated Show resolved Hide resolved
MapboxMaps.podspec Outdated Show resolved Hide resolved
MapboxMaps.podspec Outdated Show resolved Hide resolved
MapboxMaps.podspec Outdated Show resolved Hide resolved
@neelmistry94 neelmistry94 enabled auto-merge (squash) February 22, 2021 16:07
MapboxMaps.podspec Outdated Show resolved Hide resolved
MapboxMaps.podspec Outdated Show resolved Hide resolved
@neelmistry94 neelmistry94 merged commit 78d8adc into main Feb 22, 2021
@neelmistry94 neelmistry94 deleted the nm/pods_build_from_source branch February 22, 2021 17:57
@1ec5 1ec5 mentioned this pull request Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants