Refactor CameraAnimatorInterface #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macdrevx
force-pushed
the
refactor-camera-animator-interface
branch
2 times, most recently
from
c6b89b7
to
4e02508
Compare
* The animation owner for ease-to, fly-to, and gesture-deceleration animations is now `"com.mapbox.maps.cameraAnimationsManager"`. * `BasicCameraAnimator.owner` property is now public. * Animator delegates are now always internal and set after initialization. * Animators now have a standard completion block signature and standard interface for adding completion blocks. * `CameraAnimatorInterface` has been renamed to `CameraAnimatorProtocol`. * `CameraAnimatorDelegate` is now written in terms of `CameraAnimatorProtocol` instead of in terms of `CameraAnimator`.
macdrevx
force-pushed
the
refactor-camera-animator-interface
branch
from
4e02508
to
6a2e093
Compare
3 tasks
evil159
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring is part one of a series that will unlock better unit testability for
CameraAnimationsManager."com.mapbox.maps.cameraAnimationsManager".BasicCameraAnimator.ownerproperty is now public.CameraAnimatorInterfacehas been renamed toCameraAnimatorProtocol.CameraAnimatorDelegateis now written in terms ofCameraAnimatorProtocolinstead of in terms ofCameraAnimator.Pull request checklist:
## mainheading near the top).