Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve AnyTouchGestureRecognizer state management #1210

Merged
merged 3 commits into from
Mar 28, 2022
Merged

Improve AnyTouchGestureRecognizer state management #1210

merged 3 commits into from
Mar 28, 2022

Conversation

macdrevx
Copy link
Contributor

@macdrevx macdrevx commented Mar 25, 2022 •
edited
Loading

  • Sets AnyTouchGestureRecognizer.state to .failed if touches last less
    than the minimumPressDuration. This improves interaction with other
    gesture recognizers.

Fixes #1194

Pull request checklist:

  • Write tests for all new functionality. If tests were not written, please explain why.
  • Describe the changes in this PR, especially public API changes.
  • Add a changelog entry to to bottom of the relevant section (typically the ## main heading near the top).
  • Review and agree to the Contributor License Agreement (CLA).

@macdrevx
Improve AnyTouchGestureRecognizer state management
990340b 
* Sets AnyTouchGestureRecognizer.state to .failed if touches last less
  than the minimumPressDuration. This improves interaction with other
  gesture recognizers.

Fixes #1194
@macdrevx
Update changelog
78f8656
@macdrevx macdrevx mentioned this pull request Mar 25, 2022
Closed
@macdrevx macdrevx merged commit 6d44405 into main Mar 28, 2022
@macdrevx macdrevx deleted the fix/any-touch-failed branch March 28, 2022 16:10
OdNairy added a commit that referenced this pull request Aug 22, 2023
@OdNairy
Merge pull request #1210 from mapbox/feature/measure-memory-metrics
7011243 
Memory metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evil159 evil159 evil159 approved these changes

@OdNairy OdNairy Awaiting requested review from OdNairy

@maios maios Awaiting requested review from maios

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AnyTouchGestureRecognizer.canBePrevented prevents single tap gestures in Flutter environment
2 participants
@macdrevx @evil159