Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MapboxMap.coordinateBoundsUnwrapped method for API consistency. #1241

Merged
merged 4 commits into from
Apr 4, 2022
Merged

Add MapboxMap.coordinateBoundsUnwrapped method for API consistency. #1241

merged 4 commits into from
Apr 4, 2022

Conversation

pengdev
Copy link
Member

@pengdev pengdev commented Apr 4, 2022 •
edited
Loading

Add MapboxMap.coordinateBoundsUnwrapped method for API consistency.

Pull request checklist:

  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add documentation comments for any added or updated public APIs.
  • Add any new public, top-level symbols to the Jazzy config's custom_categories (scripts/doc-generation/.jazzy.yaml)
  • Describe the changes in this PR, especially public API changes.
  • Add a changelog entry to to bottom of the relevant section (typically the ## main heading near the top).
  • Update the guides (internal access only), README.md, and DEVELOPING.md if their contents are impacted by these changes.
  • Review and agree to the Contributor License Agreement (CLA).

@pengdev pengdev self-assigned this Apr 4, 2022
@pengdev pengdev changed the title Add MapboxMap::coordinateBoundsUnwrapped method for API consistency. Add MapboxMap.coordinateBoundsUnwrapped method for API consistency. Apr 4, 2022
@pengdev pengdev marked this pull request as ready for review April 4, 2022 13:08
@pengdev pengdev requested review from macdrevx and a team April 4, 2022 13:09
macdrevx
macdrevx reviewed Apr 4, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pengdev and others added 2 commits April 4, 2022 17:21
@pengdev @macdrevx
Update CHANGELOG.md
51da965 
Co-authored-by: Andrew Hershberger <andrew.hershberger@mapbox.com>
@pengdev @macdrevx
Update Sources/MapboxMaps/Foundation/MapboxMap.swift
8b3892a 
Co-authored-by: Andrew Hershberger <andrew.hershberger@mapbox.com>
@pengdev pengdev merged commit 8b29fe4 into main Apr 4, 2022
@pengdev pengdev deleted the peng-expose-coordinateBoundsForCameraUnwrapped branch April 4, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macdrevx macdrevx macdrevx approved these changes

Assignees

@pengdev pengdev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pengdev @macdrevx