Invoke animator completion handlers added after completion or cancellation #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Completion handlers added after an animator has already completed will now be invoked asynchronously on the main queue. * Fixes a crash that could occur when trying to add a completion handler to a BasicCameraAnimator that was created while animations were disabled.
macdrevx
force-pushed
the
fix/animator-crash
branch
from
d558ab7
to
71a65a6
Compare
OdNairy
approved these changes
Apr 28, 2022
| @@ -5,6 +5,7 @@ Mapbox welcomes participation and contributions from everyone. | |||
| ## main | |||
|
|
|||
| * Expose API to check whether an image exists in `Style`. ([#1297](https://github.com/mapbox/mapbox-maps-ios/pull/1297)) | |||
| * Invoke animator completion handlers added after completion or cancellation. ([#1305])(https://github.com/mapbox/mapbox-maps-ios/pull/1305)) | |||
There was a problem hiding this comment.
Suggested change
| * Invoke animator completion handlers added after completion or cancellation. ([#1305])(https://github.com/mapbox/mapbox-maps-ios/pull/1305)) | |
| * Invoke animator completion handlers added after completion or cancellation. ([#1305](https://github.com/mapbox/mapbox-maps-ios/pull/1305)) |
macdrevx
added a commit
that referenced
this pull request
May 6, 2022
OdNairy
pushed a commit
that referenced
this pull request
Aug 22, 2023
* Add codegen template for Lights * Update codegen - add experimental flags for 3D lights
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now be invoked asynchronously on the main queue.
to a BasicCameraAnimator that was created while animations were
disabled.
Pull request checklist:
## mainheading near the top).