Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layerId to AnnotationManager #189

Merged
merged 8 commits into from
Mar 18, 2021
Merged

Add layerId to AnnotationManager #189

merged 8 commits into from
Mar 18, 2021

Conversation

julianrex
Copy link
Contributor

PRs must be submitted under the terms of our Contributor License Agreement CLA.

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-ios changelog: <changelog>Added function to get layer identifier for an annotation type.</changelog>.
  • Update the migration guide, API Docs, Markdown files - Readme, Developing, etc

Summary of changes

This PR adds a function to get the layer id for a particular annotation type. It also adds a WIP convenience function (_moveLayer) to Style to allow layers to be moved. These combined give developers a method to move the underlying annotation layer.

The _moveLayer change is marked as :nodoc: and should be consider prone to change.

cc @neel

@julianrex julianrex added the feature 🍏 When working on a new feature or feature enhancement label Mar 17, 2021
@julianrex
Copy link
Contributor Author

@julianrex julianrex merged commit 2eb1bcd into main Mar 18, 2021
@julianrex julianrex deleted the jrex/annotation-options branch March 18, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🍏 When working on a new feature or feature enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants