Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MapView][Part 6] Coalesce MapView and BaseMapView #353

Merged
merged 1 commit into from
May 14, 2021

Conversation

nishant-karajgikar
Copy link
Contributor

@nishant-karajgikar nishant-karajgikar commented May 13, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-ios changelog: <changelog></changelog>.
  • Update the migration guide, API Docs, Markdown files - Readme, Developing, etc

Summary of changes

This PR coalesces MapView into BaseMapView. The resulting view continues to be called MapView. The new coalesced MapView is responsible for setting up each of the managers at the end of commonInit().

Additional supporting changes:

  1. The update() method has been removed since it doesn't do anything now that options have moved to the individual managers.
  2. The MapConfig has been deleted as it contained nothing.
  3. Various renames to MapView as necessary.

@nishant-karajgikar nishant-karajgikar force-pushed the nishantk/coalesce-mapView-and-baseMapView branch 2 times, most recently from e8b652e to 242c93e Compare May 13, 2021 21:03
@nishant-karajgikar nishant-karajgikar force-pushed the nishantk/collapse-annotation-options branch from a8cbb3c to a23346f Compare May 14, 2021 17:03
Base automatically changed from nishantk/collapse-annotation-options to main May 14, 2021 17:08
@nishant-karajgikar nishant-karajgikar force-pushed the nishantk/coalesce-mapView-and-baseMapView branch from 242c93e to fec7a82 Compare May 14, 2021 17:09
@nishant-karajgikar nishant-karajgikar enabled auto-merge (squash) May 14, 2021 17:09
@nishant-karajgikar nishant-karajgikar merged commit e85ee1c into main May 14, 2021
@nishant-karajgikar nishant-karajgikar deleted the nishantk/coalesce-mapView-and-baseMapView branch May 14, 2021 17:13
jmkiley pushed a commit that referenced this pull request May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants