-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose setFeatureState
/ getFeatureState
/ removeFeatureState
and add associated example
#611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishant-karajgikar
force-pushed
the
nishantk/featureState-3
branch
from
August 24, 2021 12:53
1e45642
to
fa88f47
Compare
nishant-karajgikar
added
the
feature 🍏
When working on a new feature or feature enhancement
label
Aug 24, 2021
nishant-karajgikar
force-pushed
the
nishantk/featureState-3
branch
from
August 24, 2021 14:24
293e49f
to
07f68d0
Compare
nishant-karajgikar
force-pushed
the
nishantk/featureState-3
branch
from
August 24, 2021 14:26
07f68d0
to
40166cb
Compare
macdrevx
reviewed
Aug 24, 2021
macdrevx
reviewed
Aug 24, 2021
macdrevx
reviewed
Aug 24, 2021
macdrevx
reviewed
Aug 24, 2021
macdrevx
reviewed
Aug 24, 2021
Tests/MapboxMapsTests/Foundation/Integration Tests/FeatureStateIntegrationTests.swift
Show resolved
Hide resolved
neelmistry94
approved these changes
Aug 24, 2021
macdrevx
reviewed
Aug 24, 2021
Co-authored-by: Andrew Hershberger <andrew.hershberger@mapbox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs must be submitted under the terms of our Contributor License Agreement CLA
Pull request checklist:
mapbox-maps-ios
changelog:<changelog></changelog>
.Summary of changes
This PR adds
setFeatureState
,getFeatureState
andremoveFeatureState
to themapboxMap
API surface. Each of these APIs are used to manage astateMap
that will be associated to a given feature.Example:
Simulator.Screen.Recording.-.iPod.touch.7th.generation.-.2021-08-24.at.08.51.34.mp4
User impact (optional)
Developers can now use these APIs to add stateful information to each feature which can then be used to drive various use cases (like styling logic in expressions).