Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose setFeatureState / getFeatureState / removeFeatureState and add associated example #611

Merged
merged 9 commits into from
Aug 25, 2021

Conversation

nishant-karajgikar
Copy link
Contributor

@nishant-karajgikar nishant-karajgikar commented Aug 24, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-ios changelog: <changelog></changelog>.
  • Update the migration guide, API Docs, Markdown files - Readme, Developing, etc

Summary of changes

This PR adds setFeatureState, getFeatureState and removeFeatureState to the mapboxMap API surface. Each of these APIs are used to manage a stateMap that will be associated to a given feature.

Example:

Simulator.Screen.Recording.-.iPod.touch.7th.generation.-.2021-08-24.at.08.51.34.mp4

User impact (optional)

Developers can now use these APIs to add stateful information to each feature which can then be used to drive various use cases (like styling logic in expressions).

@nishant-karajgikar nishant-karajgikar added the feature 🍏 When working on a new feature or feature enhancement label Aug 24, 2021
Co-authored-by: Andrew Hershberger <andrew.hershberger@mapbox.com>
@nishant-karajgikar nishant-karajgikar merged commit 995eab6 into main Aug 25, 2021
@nishant-karajgikar nishant-karajgikar deleted the nishantk/featureState-3 branch August 25, 2021 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🍏 When working on a new feature or feature enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants