Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PointAnnotation.Image's fields public #753

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Make PointAnnotation.Image's fields public #753

merged 2 commits into from
Oct 11, 2021

Conversation

macdrevx
Copy link
Contributor

Fixes: #749

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Update the changelog

Summary of changes

PointAnnotation.Image.image and .name are now public.

@macdrevx macdrevx added the skip changelog Add this label if this item does not need to be included in the changelog label Oct 11, 2021
@macdrevx macdrevx enabled auto-merge (squash) October 11, 2021 19:07
@macdrevx macdrevx merged commit 4486430 into main Oct 11, 2021
@macdrevx macdrevx deleted the ah/point-annotation-image-public-fields branch October 11, 2021 19:09
@macdrevx macdrevx mentioned this pull request Oct 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neelmistry94 neelmistry94 neelmistry94 approved these changes

Assignees
No one assigned
Labels
skip changelog Add this label if this item does not need to be included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can no longer get a PointAnnotation's image?
2 participants
@macdrevx @neelmistry94