Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set MapboxMap flags during gestures and animations #754

Merged
merged 5 commits into from
Oct 13, 2021
Merged

Set MapboxMap flags during gestures and animations #754

merged 5 commits into from
Oct 13, 2021

Conversation

macdrevx
Copy link
Contributor

@macdrevx macdrevx commented Oct 12, 2021

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Update the changelog

Summary of changes

  • Internal flags are now set appropriately when gestures or animations begin and end. This fixes an issue in which raster tiles appeared to wobble during animations and gestures.
  • Fixes an issue in which GestureManagerDelegate.gestureEnded(for:willAnimate:) was not called for the single tap gesture
  • BasicCameraAnimator now enforces that it must be in a paused state when continueAnimation(withTimingParameters:durationFactor:) is invoked.
  • MapboxMap has new public methods beginAnimation(), endAnimation(), beginGesture(), and endGesture(). Use these when implementing custom gestures or animations. Each begin invocation must always be paired with an end invocation.

@macdrevx macdrevx added the skip changelog Add this label if this item does not need to be included in the changelog label Oct 12, 2021
GestureManagerDelegate.gestureEnded(for:willAnimate:) is now called for
the single tap gesture
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@macdrevx
Copy link
Contributor Author

I realized there's a small problem with this implementation. I'll be pushing another commit soon.

@macdrevx macdrevx enabled auto-merge (squash) October 13, 2021 18:43
@macdrevx macdrevx merged commit 8654ccf into main Oct 13, 2021
@macdrevx macdrevx deleted the ah/flags branch October 13, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Add this label if this item does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants