Refactor Annotations so that the gesture recognizer is managed by the AnnotationOrchestrator #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macdrevx
reviewed
Nov 16, 2021
Co-authored-by: Andrew Hershberger <andrew.hershberger@mapbox.com>
macdrevx
reviewed
Nov 16, 2021
| func destroy() | ||
|
|
||
| /// Passes an array of feature IDs to the `AnnotationInteractionDelegate.annotationManager(_:didDetectTappedAnnotations:)` delegate method. |
There was a problem hiding this comment.
I'd either remove this line since it's for an internal method or say something like "allows distributing results of query rendered features to annotation managers"
macdrevx
reviewed
Nov 16, 2021
Tests/MapboxMapsTests/Annotations/Mocks/MockAnnotationInteractionDelegate.swift
Outdated
Show resolved
Hide resolved
macdrevx
approved these changes
Nov 16, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
Pull request checklist:
mapbox-maps-ioschangelog:<changelog></changelog>.Summary of changes
This PR:
*AnnotationManager.handleTap(_:)method to theAnnotationOrchestrator.AnnotationManagerInternalprotocol to include adelegateproperty andhandleQueriedFeatures()method.*AnnotationManager.handleQueriedFeatures(_:)method takes an array of layer ID strings fromAnnotationOrchestrator.handleTap(_:). If any of annotations for that manager have that ID, we will call the appropriate delegate method.User impact (optional)
This is so features are queried only once per tap, even with multiple annotation managers.