Fix to only localize the primary localization and not the fall-throug… #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
My first PR here 😀 |
macdrevx
reviewed
Nov 23, 2021
macdrevx
reviewed
Nov 23, 2021
macdrevx
reviewed
Nov 23, 2021
macdrevx
approved these changes
Nov 23, 2021
macdrevx
pushed a commit
that referenced
this pull request
Dec 2, 2021
#856) * Fix to only localize the primary localization and not the fall-through localizations
macdrevx
added a commit
that referenced
this pull request
Dec 2, 2021
* Fix StyleColor tests for iOS 12 and lower (#847) * Make persistent layer APIs non-experimental (#849) * Generate private module interface (#854) * Fix changelog (#857) * Fix to only localize the primary localization and not the fall-throug… (#856) * Exclude swiftlint config from packaged artifact (#859) * View Annotations follow-up (#846) * Reduce geometry wrapping using GeometryConvertible (#861) * Update baselines to new format (#863) * Delay adding puck images until adding layer (#862) * Add missing StyleColor support for exponentials (#873) * Fix attribution dialog initialization (#865) * Add v10.0.2 to CHANGELOG.md (#883) * Improve panning behavior on pitched maps (#888) * Add pinch gesture tradeoff configuration option (#890) * Update MapboxCoreMaps and MapboxCommon (#891) * Update changelog and bump version for v10.2.0-rc.1 (#892)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…h localizations
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: #855
Pull request checklist:
- [ ] Include before/after visuals or gifs if this PR includes visual changes.- [ ] Document any changes to public APIs.mapbox-maps-ioschangelog:<changelog></changelog>.Summary of changes
Reduces the programatically set localization to the primary localization, instead of overriding all fallbacks with the primary.
Eg. layer defines: name_en, name_de, name - localizeLabales("ko") no longer results in: name_ko, name_ko, name - but in name_ko, name_de, name.
This should help until we can have: #653
to hopefully also programatically set all fallback languages.
No tests added, since existing cover the previously expected behavior.
User impact (optional)
a customer with be able ship their v10 migration