Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce geometry wrapping using GeometryConvertible #861

Merged
merged 3 commits into from
Nov 24, 2021
Merged

Reduce geometry wrapping using GeometryConvertible #861

merged 3 commits into from
Nov 24, 2021

Conversation

macdrevx
Copy link
Contributor

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Update the changelog

Summary of changes

  • Updates ViewAnnotationOptions.init to accept a GeometryConvertible instead of a Geometry to reduce redundant wrapping.
  • Makes similar changes to some internal APIs.
  • Renames and reorganizes some files.
  • Removes unnecessary .inits
  • Updates CHANGELOG.md

@macdrevx macdrevx added the feature 🍏 When working on a new feature or feature enhancement label Nov 24, 2021
@macdrevx macdrevx enabled auto-merge (squash) November 24, 2021 16:06
endanke
endanke approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@endanke endanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes 👍

@macdrevx macdrevx merged commit 0ad90be into main Nov 24, 2021
@macdrevx macdrevx deleted the ah/geometry-convertible branch November 24, 2021 16:12
macdrevx added a commit that referenced this pull request Dec 2, 2021
@macdrevx
Reduce geometry wrapping using GeometryConvertible (#861)
f554f56
@macdrevx macdrevx mentioned this pull request Dec 2, 2021
Merged
macdrevx added a commit that referenced this pull request Dec 2, 2021
@macdrevx
Add changes from main branch for v10.2.0-rc.1 (#893)
7d9359b 
* Fix StyleColor tests for iOS 12 and lower (#847)

* Make persistent layer APIs non-experimental (#849)

* Generate private module interface (#854)

* Fix changelog (#857)

* Fix to only localize the primary localization and not the fall-throug… (#856)

* Exclude swiftlint config from packaged artifact (#859)

* View Annotations follow-up (#846)

* Reduce geometry wrapping using GeometryConvertible (#861)

* Update baselines to new format (#863)

* Delay adding puck images until adding layer (#862)

* Add missing StyleColor support for exponentials (#873)

* Fix attribution dialog initialization (#865)

* Add v10.0.2 to CHANGELOG.md (#883)

* Improve panning behavior on pitched maps (#888)

* Add pinch gesture tradeoff configuration option (#890)

* Update MapboxCoreMaps and MapboxCommon (#891)

* Update changelog and bump version for v10.2.0-rc.1 (#892)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endanke endanke endanke approved these changes

Assignees
No one assigned
Labels
feature 🍏 When working on a new feature or feature enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macdrevx @endanke