Delay adding puck images until adding layer #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
functional ✅ |
OdNairy
approved these changes
Nov 25, 2021
macdrevx
added a commit
that referenced
this pull request
Dec 2, 2021
macdrevx
added a commit
that referenced
this pull request
Dec 2, 2021
* Fix StyleColor tests for iOS 12 and lower (#847) * Make persistent layer APIs non-experimental (#849) * Generate private module interface (#854) * Fix changelog (#857) * Fix to only localize the primary localization and not the fall-throug… (#856) * Exclude swiftlint config from packaged artifact (#859) * View Annotations follow-up (#846) * Reduce geometry wrapping using GeometryConvertible (#861) * Update baselines to new format (#863) * Delay adding puck images until adding layer (#862) * Add missing StyleColor support for exponentials (#873) * Fix attribution dialog initialization (#865) * Add v10.0.2 to CHANGELOG.md (#883) * Improve panning behavior on pitched maps (#888) * Add pinch gesture tradeoff configuration option (#890) * Update MapboxCoreMaps and MapboxCommon (#891) * Update changelog and bump version for v10.2.0-rc.1 (#892)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #860
Pull request checklist:
Summary of changes
Fixes an issue that caused the location puck to fail to render if it was configured prior to the style loading and the first location update didn't happen until after the style loaded.
Previously, the style images were added to the style as soon as the puck was activated. However, in the situation described above, the persistent puck layer would not be added until after the style loaded. MapboxCoreMaps clears style images during reload if there are no persistent layers. That meant that the puck images were missing when the puck layer was finally added.
This fix updates the logic to delay adding the images to the style until it's time to add the persistent layer.