Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribution dialog initialization #865

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Fix attribution dialog initialization #865

merged 1 commit into from
Nov 29, 2021

Conversation

vayesh
Copy link
Contributor

@vayesh vayesh commented Nov 25, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-ios changelog: <changelog></changelog>.
  • Update the migration guide, API Docs, Markdown files - Readme, Developing, etc

Summary of changes

PR fixes the attribution dialog to reflect telemetry opt-in-out status correctly at first appearance.

User impact (optional)

@vayesh vayesh added the bug 🪲 Something is broken! label Nov 25, 2021
@vayesh vayesh marked this pull request as ready for review November 29, 2021 17:11
@vayesh vayesh merged commit 7e67910 into main Nov 29, 2021
@vayesh vayesh deleted the vesh93/telemetry_fix branch November 29, 2021 18:25
macdrevx pushed a commit that referenced this pull request Dec 2, 2021
macdrevx added a commit that referenced this pull request Dec 2, 2021
* Fix StyleColor tests for iOS 12 and lower (#847)

* Make persistent layer APIs non-experimental (#849)

* Generate private module interface (#854)

* Fix changelog (#857)

* Fix to only localize the primary localization and not the fall-throug… (#856)

* Exclude swiftlint config from packaged artifact (#859)

* View Annotations follow-up (#846)

* Reduce geometry wrapping using GeometryConvertible (#861)

* Update baselines to new format (#863)

* Delay adding puck images until adding layer (#862)

* Add missing StyleColor support for exponentials (#873)

* Fix attribution dialog initialization (#865)

* Add v10.0.2 to CHANGELOG.md (#883)

* Improve panning behavior on pitched maps (#888)

* Add pinch gesture tradeoff configuration option (#890)

* Update MapboxCoreMaps and MapboxCommon (#891)

* Update changelog and bump version for v10.2.0-rc.1 (#892)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something is broken!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants