Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Metal view has a non-zero area #903

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Ensure Metal view has a non-zero area #903

merged 1 commit into from
Dec 7, 2021

Conversation

macdrevx
Copy link
Contributor

@macdrevx macdrevx commented Dec 6, 2021

Fixes a crash that could occur otherwise.

cc: @pjleonard37

@macdrevx
Ensure Metal view has a non-zero area
92ff72f 
Fixes a crash that could occur otherwise.
pjleonard37
pjleonard37 approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@pjleonard37 pjleonard37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@macdrevx macdrevx merged commit cf8d263 into main Dec 7, 2021
@macdrevx macdrevx deleted the fix/zero-area-metal-view-crash branch December 7, 2021 02:13
OdNairy pushed a commit that referenced this pull request Dec 15, 2021
@macdrevx @OdNairy
Ensure Metal view has a non-zero area (#903)
4ff3ab3
OdNairy added a commit that referenced this pull request Dec 15, 2021
@OdNairy @macdrevx
10.2 (#953)
f8f4bb5 
* Update CoreMaps to 10.2.0, Common to 21.0.1

* Ensure Metal view has a non-zero area (#903)

Co-authored-by: Andrew Hershberger <andrew.hershberger@mapbox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjleonard37 pjleonard37 pjleonard37 approved these changes

@OdNairy OdNairy Awaiting requested review from OdNairy

@pengdev pengdev Awaiting requested review from pengdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macdrevx @pjleonard37