Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set location for 2D puck when accuracy is reduced #989

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Set location for 2D puck when accuracy is reduced #989

merged 2 commits into from
Jan 4, 2022

Conversation

macdrevx
Copy link
Contributor

@macdrevx macdrevx commented Jan 4, 2022 •
edited
Loading

Fixes #983

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Update the changelog

Summary of changes

Fixes a bug where 2D puck location was never set when location accuracy authorization was reduced.

@macdrevx macdrevx added the bug 🪲 Something is broken! label Jan 4, 2022
ZiZasaurus
ZiZasaurus approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@ZiZasaurus ZiZasaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works / LGTM!

@macdrevx macdrevx enabled auto-merge (squash) January 4, 2022 20:52
@macdrevx macdrevx disabled auto-merge January 4, 2022 20:54
@macdrevx macdrevx force-pushed the ah/fix-reduced-accuracy-location branch from 415a8fc to 9ef88cb Compare January 4, 2022 20:55
@macdrevx macdrevx enabled auto-merge (squash) January 4, 2022 20:55
@macdrevx macdrevx merged commit 5292073 into main Jan 4, 2022
@macdrevx macdrevx deleted the ah/fix-reduced-accuracy-location branch January 4, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZiZasaurus ZiZasaurus ZiZasaurus approved these changes

Assignees
No one assigned
Labels
bug 🪲 Something is broken!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show reduced accuracy location as circle
2 participants
@macdrevx @ZiZasaurus