Fix pan drift with non-zero bearing #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macdrevx
force-pushed
the
ah/fix-pan-drift
branch
from
9b65c5c
to
1293b77
Compare
macdrevx
commented
Feb 12, 2021
macdrevx
force-pushed
the
ah/fix-pan-drift
branch
from
1293b77
to
30bbbb0
Compare
neelmistry94
approved these changes
Feb 12, 2021
macdrevx
force-pushed
the
ah/fix-pan-drift
branch
from
30bbbb0
to
e3ba61a
Compare
| // cameraView.centerCoordinate is allowed to exceed [-180, 180] | ||
| // so that core animation interpolation works correctly when | ||
| // crossing the antimeridian. We wrap here to hide that implementation | ||
| // detail when accessing centerCoordinate via BaseMapView |
- The directionality of the antimeridian correction was being calculated under the assumption that the bearing was 0. With a non-zero bearing, we need to instead consider the component of the offset that runs due east.
macdrevx
force-pushed
the
ah/fix-pan-drift
branch
from
e3ba61a
to
9e8c771
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
mapbox-maps-ioschangelog:<changelog>Fixed: Pan drift did not work correctly when bearing was non-zero.</changelog>.Summary of changes