Fix bug with setting options on LocationManager #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocationProvider is not constrained to be a class, so when syncOptions() was called, it triggered the setter for the property that stored it rather than merely setting a property on the object itself. This caused the location provider to be stopped and restarted and have its delegate reconfigured each time options were set on LocationManager.
macdrevx
force-pushed
the
fix/location-provider-did-set
branch
from
31d9fff
to
dcf7e64
Compare
ShanMa1991
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
Summary of changes
LocationProvider is not constrained to be a class, so when syncOptions() was called, it triggered the setter for the property that stored it rather than merely setting a property on the object itself. This caused the location provider to be stopped and restarted and have its delegate reconfigured each time options were set on LocationManager.
In v11, let's plan to constrain LocationProvider to AnyObject and remove this workaround.