Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapbox Navigation SDK v2.1.2 #3849

Merged
merged 4 commits into from
Apr 26, 2022
Merged

Mapbox Navigation SDK v2.1.2 #3849

merged 4 commits into from
Apr 26, 2022

Conversation

jill-cardamon
Copy link
Contributor

Patch release of Mapbox Navigation SDK v2.1.2 that includes:

@mapbox-github-ci-issues-public-1
Copy link

Breaking Changes in MapboxCoreNavigation

Breaking API Changes

NavigationRouteOptions

  • removed method: init(waypoints:profileIdentifier:) in NavigationRouteOptions
  • removed method: init(coordinates:profileIdentifier:) in NavigationRouteOptions
  • removed method: init(locations:profileIdentifier:) in NavigationRouteOptions

NavigationMatchOptions

  • removed method: init(locations:profileIdentifier:) in NavigationMatchOptions
  • removed method: init(waypoints:profileIdentifier:) in NavigationMatchOptions
  • removed method: init(coordinates:profileIdentifier:) in NavigationMatchOptions

@mapbox-github-ci-issues-public-1
Copy link

No breaking changes detected in MapboxNavigation

@jill-cardamon
Copy link
Contributor Author

Breaking changes bot is complaining because listed methods have new argument with a default value. It will not lead to any code updates on user side to adopt this version.

@mapbox-github-ci-issues-public-1
Copy link

Breaking Changes in MapboxCoreNavigation

Breaking API Changes

NavigationRouteOptions

  • removed method: init(coordinates:profileIdentifier:) in NavigationRouteOptions
  • removed method: init(waypoints:profileIdentifier:) in NavigationRouteOptions
  • removed method: init(locations:profileIdentifier:) in NavigationRouteOptions

NavigationMatchOptions

  • removed method: init(waypoints:profileIdentifier:) in NavigationMatchOptions
  • removed method: init(coordinates:profileIdentifier:) in NavigationMatchOptions
  • removed method: init(locations:profileIdentifier:) in NavigationMatchOptions

@mapbox-github-ci-issues-public-1
Copy link

No breaking changes detected in MapboxNavigation

@jill-cardamon jill-cardamon self-assigned this Apr 25, 2022
@jill-cardamon jill-cardamon added the build Issues related to builds and dependency management. label Apr 25, 2022
@1ec5 1ec5 mentioned this pull request Apr 26, 2022
Closed
1ec5
1ec5 approved these changes Apr 26, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@mapbox-github-ci-issues-public-1
Copy link

Breaking Changes in MapboxCoreNavigation

Breaking API Changes

NavigationMatchOptions

  • removed method: init(locations:profileIdentifier:) in NavigationMatchOptions
  • removed method: init(waypoints:profileIdentifier:) in NavigationMatchOptions
  • removed method: init(coordinates:profileIdentifier:) in NavigationMatchOptions

NavigationRouteOptions

  • removed method: init(coordinates:profileIdentifier:) in NavigationRouteOptions
  • removed method: init(waypoints:profileIdentifier:) in NavigationRouteOptions
  • removed method: init(locations:profileIdentifier:) in NavigationRouteOptions

@mapbox-github-ci-issues-public-1
Copy link

No breaking changes detected in MapboxNavigation

MaximAlien
MaximAlien approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@MaximAlien MaximAlien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to push podspec.

@jill-cardamon jill-cardamon merged commit df7b204 into release-v2.1 Apr 26, 2022
@jill-cardamon jill-cardamon deleted the jill/release-v2.1.2 branch April 26, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ec5 1ec5 1ec5 approved these changes

@MaximAlien MaximAlien MaximAlien approved these changes

Assignees

@jill-cardamon jill-cardamon

Labels
build Issues related to builds and dependency management.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jill-cardamon @1ec5 @MaximAlien