Fix localization in End of route view #4494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ja translation for "End Navigation"
S2Ler
force-pushed
the
s2/fix-feedback-screen-localization
branch
from
10fd827
to
b96f151
Compare
Codecov Report
@@ Coverage Diff @@
## main #4494 +/- ##
==========================================
- Coverage 59.98% 59.97% -0.01%
==========================================
Files 189 189
Lines 21192 21194 +2
==========================================
Hits 12712 12712
- Misses 8480 8482 +2
|
kried
approved these changes
Jul 5, 2023
| @@ -1,3 +1,6 @@ | |||
|
|
|||
| /* Class = "UILabel"; text = "Rate your trip"; ObjectID = "W5U-cV-cDO"; */ | |||
| "W5U-cV-cDO.text" = "今回の乗車の評価を行う"; | |||
|
|
|||
| /* Class = "UIButton"; normalTitle = "End Navigation"; ObjectID = "5f2-dT-la4"; */ | |||
There was a problem hiding this comment.
Don't we need to add other localized labels in Japanese?
There was a problem hiding this comment.
We localize SDK using transifex service. We will check if it works after latest changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add ja translation for "End Navigation"
Fixes #4492