Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying plots on map, with no property, choosing a colour and a size. #13

Closed
rvlander opened this issue Oct 4, 2017 · 7 comments
Closed

Comments

@rvlander
Copy link

rvlander commented Oct 4, 2017

This appears not to be possible currently and it would be a huge gain.

@ryanbaumann
Copy link
Contributor

ryanbaumann commented Oct 8, 2017

@rvlander Sounds like you want to be able to display data with just point geometries, no property values, while selecting the default color and size?

I think we should do this by exposing the default Mapbox GL Style Spec property for a data-driven style via a Python option in the mapboxgl library. This would allow you to specify a default circle radius, circle color, or any other style property in the case where there is no property value to parse for a data-driven style.

@rvlander
Copy link
Author

rvlander commented Oct 9, 2017

@ryanbaumann, yes it is what would be need.

@ryanbaumann
Copy link
Contributor

@rvlander excellent. I'll add this as a feature for the next release.

@ryanbaumann
Copy link
Contributor

ryanbaumann commented Jan 2, 2018

Adding that we should support a default color profile for all viz types if no color style is passed by the user.

@ryanbaumann
Copy link
Contributor

ryanbaumann commented Feb 3, 2018

This should be possible now using the color_default and color_function_type options:

mapboxgl.viz.CircleViz(data, color_function_type="match", color_default="grey")

Need to add:

  • Add radius style option to CircleViz
  • If colorStops=None generate an empty expression

@ryanbaumann
Copy link
Contributor

Working on this in this PR - #48

@ryanbaumann
Copy link
Contributor

Closed in #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants