Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CircleViz doesn't plot data if color_stops is None #60

Closed
EtienneDesticourt opened this issue Mar 2, 2018 · 2 comments
Closed

CircleViz doesn't plot data if color_stops is None #60

EtienneDesticourt opened this issue Mar 2, 2018 · 2 comments
Labels
bug
Milestone
0.6.0

Comments

@EtienneDesticourt
Copy link
Contributor

Hi,

I was trying to plot a CircleViz and my points wouldn't appear. Once I supplied the color_stops argument they showed up.
If color_stops are required to plot data they should raise an error when missing, or be set to a meaningful default.
Related to #13 I think.

Cheers
@ryanbaumann ryanbaumann added the bug label Mar 3, 2018
@ryanbaumann
Copy link
Contributor

@EtienneDesticourt thanks for the bug report. Yes, all style properties should be clearer whether or not they accept singular values, or values that are expressions or arrays like color_stops.

Started work on this in this PR - #48

@ryanbaumann ryanbaumann added this to the 0.6.0 milestone Mar 25, 2018
@ryanbaumann
Copy link
Contributor

Closed in #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
2 participants
@ryanbaumann @EtienneDesticourt