increases max zoom levels for raster uploads #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@isiyu y. |
| @@ -410,9 +410,9 @@ tape('[SPATIAL RESOLUTIONS] Get spatial resolutions / valid spatial resolutions' | |||
| assert.end(); | |||
| }); | |||
|
|
|||
| tape('[SPATIAL RESOLUTIONS] Get spatial resolutions / valid spatial resolutions with weight 0.5', function(assert) { | |||
| tape('[SPATIAL RESOLUTIONS] Get spatial resolutions / valid spatial resolutions with weight 0.25', function(assert) { | |||
There was a problem hiding this comment.
Curious @isiyu - why did this test change?
There was a problem hiding this comment.
I changed the description - it said it was with weight 0.5 but the call below on line 418 was using weight 0.25
tests for if pixel resolution is over and under getValidSpatialResolutions threshold
… supporting node v0.12
| @@ -87,7 +87,7 @@ module.exports.getUnitType = function(srs) { | |||
|
|
|||
| module.exports.getSpatialResolutions = function() { | |||
| var circumference = 40075000; | |||
| var zoomLevels = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19]; | |||
| var zoomLevels = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20]; | |||
There was a problem hiding this comment.
@GretaCB @isiyu maxzoom is zoomLevels.length (https://github.com/mapbox/mapnik-omnivore/blob/moremaxzoom/lib/raster.js#L179), which means that this is 21. That said, previous maxzoom was 20 (not 19, as I think we've assumed / verified on master and on branch setup from modularization a0c4cda), so I think bumping it to 21 (maxzoom of 22 - 2 more zooms) would be 👍
This reverts commit 3b7b6ee.
isiyu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://github.com/mapbox/unpacker/issues/852
@dnomadb does this need more
SPATIAL RESOLUTIONStests for the new zoom levels?