Added option for synchronous map loading #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes there's a sneaky race condition with map initialization, which seems to be solved by loading maps synchronously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In creating a module to be run in an Electron render thread, I was running into an apparent race condition with creating many pooled instances simultaneously on load (the issue seems similar to that in mapnik/mapnik#1459).
I was able to solve the issue by synchronously loading mapfiles using the
map.fromStringSyncmethod. Here, I've added this as an option (disabled by default) for mapnik-pool. I've added some tests and it appears that everything works well. There are no changes to the API except a booleansyncflag ininitOptions.