Set BOOST_TOOLSET* from CC and CXX env variables. #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for noticing and fixing. Also thanks for all your other PRs - very appreciated. I am busy but I'll do my best to respond and merge when I can. As far as this one: did you have a chance to test? I worry that these arguments expect a compiler name rather than a path and CXX/CC might provide a full path - can you test that? Then, happy to merge. |
Using basename of given C and C++ compiler paths seems to work for the common cases of gcc and clang.
tpikonen
force-pushed
the
boost_toolset
branch
from
b514a38
to
fab963a
Compare
|
You're correct, Boost build system does not work with BOOST_TOOLSET* set to binaries with full path. Fortunately the basename of the full paths works for (at least) the common compilers of gcc and clang. I've updated the patch accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build scripts for boost currently have the toolset hardcoded to clang. Most linux systems have gcc as the default compiler, which makes the build fail without installing an additional compiler. This patch sets the BOOST_TOOLSET* variables from the CC and CXX environment variables, which should be set to reasonable defaults in mason.sh.