Add fixture with a linestring geometry that contains a ClosePath command #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapsam
reviewed
Apr 13, 2018
There was a problem hiding this comment.
@anandthakker this looks really great! The only thing I'm hesitant about is the addition of documentation.js to the package.json ... it's such a huge dependency that I always get scared adding it directly, and just make a note in the README to have it installed globally. That said, I could be convinced that explicitly stating the version will prevent API.md diffs from happening much in the future. Curious how you feel!
|
@anandthakker I just synced this up with master. Required updating the fixture number to 061 and I removed the documentation dependency to reduce package size. This will go out in 3.5.0 - thanks! |
|
🙇 sorry to have dropped the ball here @mapsam -- thanks for picking it up for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs mapbox/mapbox-gl-native#11579
Found in a mapbox-gl-native test fixture, most likely from an old version mapbox streets. As mentioned in the description, this is potentially relevant in practice because users of mapbox-gl-native could have offline caches that contain tiles like this one.