This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Line cover #32

Closed

tmcw opened this issue Jul 15, 2014 · 6 comments

Contributor

tmcw commented Jul 15, 2014

No description provided.

tmcw added a commit that referenced this issue


          Work on coverings for polylines. Refs #32

61d0804

Contributor Author

tmcw commented Jul 15, 2014

Started work on this, but I'm not sure whether S2Polyline is the path to take.

tmcw mentioned this issue

LineString support mapbox/cardboard#16

Closed

Contributor

morganherlocker commented Jul 18, 2014

s2map just treats lines as polygons, although we probably do not want to.

relevant code in the s2map server:
https://github.com/blackmad/s2map/blob/master/s2map-server/http-server.c#L189

examples:
http://s2map.com/#order=lnglat&mode=line&s2=true&s2_min_level=1&s2_max_level=30&s2_max_cells=200&s2_level_mod=1&points="coordinates":[%0A[%0A-95.16357421875,%0A32.45415593941475%0A],%0A[%0A-93.09814453125,%0A32.2313896627376%0A],%0A[%0A-89.5166015625,%0A32.731840896865684%0A],%0A[%0A-87.07763671875,%0A35.8356283888737%0A],%0A[%0A-87.51708984375,%0A36.50963615733049%0A]%0A]

http://s2map.com/#order=lnglat&mode=line&s2=true&s2_min_level=1&s2_max_level=30&s2_max_cells=200&s2_level_mod=1&points="coordinates":[%0A[%0A-91.153564453125,%0A31.606609719226917%0A],%0A[%0A-92.88940429687499,%0A34.31621838080741%0A],%0A[%0A-89.000244140625,%0A33.770015152780125%0A],%0A[%0A-90.9228515625,%0A36.4566360115962%0A],%0A[%0A-87.154541015625,%0A36.30627216957992%0A]%0A]

Contributor

morganherlocker commented Jul 21, 2014

Polylines are passing tests with valid cells being returned fb7a9af

morganherlocker closed this as completed

tmcw reopened this

Contributor Author

tmcw commented Aug 7, 2014

Polylines now exposed in 479c184

Contributor

DennisOSRM commented Aug 14, 2014

@tmcw Are we good here?

Contributor Author

tmcw commented Aug 14, 2014

👍 this is covered

tmcw closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.