Add --unique option to support spritezero's generateLayoutUnique #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also regenerate fixtures since they were stale. A fresh copy of origin/master fails to run tests since it picks up spritezero 3.5+ which switched to shelf-pack instead of bin-pack.
vdumont
changed the title
vdumont
changed the title
|
@bhousel This is the companion patch that adds |
|
|
||
| if (argv.retina) { | ||
| ratio = 2; | ||
| } else if (argv.ratio) { | ||
| ratio = parseFloat(argv.ratio); | ||
| } else if (argv.unique) { |
There was a problem hiding this comment.
This shouldn't be an exclusive option to argv.ratio - else if will mean that if argv.ratio is defined, the argv.unique option will not have an effect, which is incorrect.
|
Looks good @vdumont, thanks! |
|
@bhousel Awesome, thanks much! |
|
@bhousel Sorry forgot one thing, any chance you can tag this for a new release? |
|
Awesome, thank you so much! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --unique option to support spritezero's
generateLayoutUnique.Also regenerate fixtures since they were stale. ie: A fresh copy of origin/master fails to run tests since it picks up spritezero 3.5+ which switched to shelf-pack instead of bin-pack.