Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade strxml to fix warnings related to tap included in build #31

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kriscarle
Copy link

This was still using the original version of strxml that included tap in dependences. All the tests are passing again.

This is mainly to fix security warnings coming from old versions of uglify etc. that are pulled in by this repo https://snyk.io/test/npm/tokml/0.4.0

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 05bb2a3 on kriscarle:master into 91c3fa5 on mapbox:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b1bb13f on kriscarle:master into 91c3fa5 on mapbox:master.

@bobi7
Copy link

bobi7 commented Nov 7, 2018

Will there be any work done on this?

@kszafran
Copy link

+1

Now that nsp check no longer works and npm audit does not allow ignoring vulnerabilities as of now (not even mentioning yarn audit...) this is pretty problematic.

@kriscarle
Copy link
Author

@kszafran @bobi7 It doesn't seem like Mapbox is still using or maintaining this code, so I went ahead and converted this PR to a fork, and published v0.5.0 here https://www.npmjs.com/package/@maphubs/tokml

@kszafran
Copy link

@kriscarle I actually switched to your fork yesterday. Thanks for publishing it to npm!

gabrieldeal added a commit to gabrieldeal/route-wizard that referenced this pull request Jan 27, 2020
by switching to a version of `tokml` that is being (somewhat?) maintained.
mapbox/tokml#31 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants