Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap everything in a transform stream #6

Merged
merged 18 commits into from
Feb 11, 2015
Merged

Conversation

ian29
Copy link
Contributor

@ian29 ian29 commented Feb 11, 2015

@dnomadb ok i know inflator.js is not async, but we can come back to that. this now works they way i want.

changes

  • inflator + aggregator are wrapped in a transform stream. tho i think we can pass through inflate/agg (should maybe call this inflate-stream or so?
  • inflator.js is sync: json data in, geojson triangles out ( i know, i know )
  • aggregator.js is still uses prototype
  • aggregator.js not longer calls inflator (all the getParent + eatData logic is moved to the transform stream constructor in index.js
  • the new getParent function, known creatively as agg() get called recursively until the minZ is reached https://github.com/mapbox/trizilla/blob/inflator-wrapper/index.js#L33

test

test z8 aggregated down to z5 like

$ time cat test/fixtures/fillfacets-output | node test/eater.test.js > /dev/null
real    0m5.441s
user    0m5.216s
sys 0m0.267s

:D

next

@dnomadb this PR is to better-stream but im not sure how best to incorporate your tiling work. i would love to merge this to better-stream and then better-stream to master

@dnomadb
Copy link
Contributor

dnomadb commented Feb 11, 2015

i would love to merge this to better-stream and then better-stream to
master

Yes, this sounds good. We can then work in the tiling logic

@ian29
Copy link
Contributor Author

ian29 commented Feb 11, 2015

woo ok. gonna push some green buttons. then lets get your tiling work merged into master too.

ian29 added a commit that referenced this pull request Feb 11, 2015
wrap everything in a transform stream
@ian29 ian29 merged commit 9cfd0bb into better-stream Feb 11, 2015
@ian29 ian29 deleted the inflator-wrapper branch February 11, 2015 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants