Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature.coordinates #5

Closed
springmeyer opened this issue Oct 31, 2016 · 2 comments
Closed

Remove feature.coordinates #5

springmeyer opened this issue Oct 31, 2016 · 2 comments

Comments

@springmeyer
Copy link

We are currently outputting both feature.coordinates and feature.geometry.coordinates. The former is the result of layer.feature(i).loadGeometry(); which is a custom structure of x,y in tile coordinates. The latter is geojson coordinates. I think we should output only the latter by removing this line:

@@ -69,7 +78,6 @@ function readTile(args, buffer, callback) {
         var layer = tile.layers[layerID];
         for (var i = 0; i < layer.length; i++) {
             var feature = layer.feature(i).toGeoJSON(args.x, args.y, args.z);
-            feature.coordinates = layer.feature(i).loadGeometry();
             collection.features.push(feature);
         }
     });

/cc @jfirebaugh who might remember if there was a reason for feature.coordinates = layer.feature(i).loadGeometry();.

@jfirebaugh
Copy link
Contributor

No reason that I'm aware of.

@mapsam
Copy link
Contributor

mapsam commented Apr 21, 2017

This was resolved in #12 and has been released in @mapbox/vt2geojson@1.1.3

@mapsam mapsam closed this as completed Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants