1.0.0 - localize #127
Merged
1.0.0 - localize #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: John Klancer <john.klancer@mapbox.com>
Co-authored-by: John Klancer <john.klancer@mapbox.com>
* 1st pass at adding worldview into params * - basic worldview support * [publish binary] 1.0.0-dev2 * - adds support for comma-separated worldviews * [publish binary] 1.0.0-dev3 * testing changes: - combine lang + worldview - verify ID is not added - check geometry * linting internationalize test * moving test util function * readme tweaks; * removing todo comments * very wip to replicate legacy worldview features * wip2] * cleanup cleanup everybody everywhere * i18n worldview tests * uncomment binding * tidy and format * v1.0.0-dev4 [publish binary] * uncomment binding [publish binary] * test with whacky/mismatching worldview values * update and split docs * update xcode12.4 and remove CXX flags * revert xcode changes * Update README.md Co-authored-by: John Klancer <john.klancer@mapbox.com> * Update README.md Co-authored-by: John Klancer <john.klancer@mapbox.com> * Update README.md Co-authored-by: John Klancer <john.klancer@mapbox.com> * Update README.md Co-authored-by: John Klancer <john.klancer@mapbox.com> * utils functions for split and intersect * uncomment binding.gyp * std::begin -> begin() / end(), var renaming * swap order of build_internationalized_feature parameters * tidy and format * revert clang versions * 1.0.0-dev5 [publish binary] Co-authored-by: mapsam <matthews.sam@gmail.com> Co-authored-by: Sam Matthews <sam@mapbox.com>
* internationalize -> localize * uncomment binding * Update src/vtcomposite.cpp Co-authored-by: John Klancer <john.klancer@mapbox.com> * Update src/vtcomposite.cpp Co-authored-by: John Klancer <john.klancer@mapbox.com> * Update README.md Co-authored-by: John Klancer <john.klancer@mapbox.com> * 1.0.0-dev6 [publish binary] * Update README.md Co-authored-by: Rajesh Amradi <rajesh.amradi@mapbox.com> * use mvt-fixtures 3.8.0 Co-authored-by: John Klancer <john.klancer@mapbox.com> Co-authored-by: Rajesh Amradi <rajesh.amradi@mapbox.com>
* localize(params), worldview_property option * worldview_defaults, tests with inline mvt fixtures * use mvt-fixtures 3.9.0 * update README * remove worldview_defaults param, update readme + tests * update param validation tests * review feedback * Update README.md Co-authored-by: John Klancer <john.klancer@mapbox.com> * Update README.md Co-authored-by: John Klancer <john.klancer@mapbox.com> * tidy and format * 1.0.0-dev7 [publish binary] Co-authored-by: John Klancer <john.klancer@mapbox.com>
* language_property, language_prefix * add params.language_property and params.language_prefix test * add language params docs * make format * fix test name
davidweimapbox
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new function named
localize, intended for finding language and worldviews within an encoded vector tile and modifying properties to "translate" them, as well as drop unused translations to keep tile size small.The original
compositefunction is now accessible via: