Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable LTO #63

Closed
wants to merge 1 commit into from
Closed

Enable LTO #63

wants to merge 1 commit into from

Conversation

springmeyer
Copy link
Contributor

This enables Link Time Optimization for the vtquery build.

Learn more about why LTO is important at https://github.com/mapbox/cpp/blob/d7b1681d650f600940652744a31fd019195e9c31/glossary.md#link-time-optimization

This will ensure that vtquery code runs as fast as possible even if we split the code into more .cpp files as part of #14.

Next steps:

  • I ported vtquery here to ensure this works, now that it does, it also needs to be backported to node-cpp-skel
  • Run basic benchmarks on linux (inside docker container) to make sure code is actually just as fast (should see no difference).

refs mapbox/cpp#49

@springmeyer
Copy link
Contributor Author

closing, this is landing in node-cpp-skel over in mapbox/node-cpp-skel#111. Will handle "forward-porting" separately. This PR was purely to test the concept.

@springmeyer springmeyer deleted the lto branch March 28, 2018 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants