-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinch to zoom no longer works on OSX, causing unwanted jump to 1% zoom #1305
Comments
That's bad news. Unfortunately, I have no way to test this myself. :S Since I don't think I changed anything related to this in Tiled 0.16, I fear it may be a Qt bug. I'll have to check which version of Qt Tiled 0.15 was built against to see if it could be a regression. Also, could you try if this still happens in the current snapshot, which is built against Qt 5.6? |
Hi Bjorn, I just had a look at the new OS X snapshot.. It's different :p It does not go to 1% anymore, but what happens now is the following: 200% zoom I hope this makes sense, if extra information is needed for debug I could record my screen. |
Tiled 0.17 was released against Qt 5.7. Did that change anything regarding this issue? |
Hi, sorry for the late reply. |
@pouwelsjochem I'm sad to hear it's still there. A recording could be illustrative. Ultimately, I'm wondering how to reproduce this issue myself. I recently got a Wacom Intuos Pro and I wonder if I could reproduce it if connected to my Mac Mini. |
Ah alright, perhaps that will also result in the same bug. But for now, here's the video :) Explanation of what is happening:
|
Pinch to zoom also does not work with windows 10 tablet mode Tiled v 0.18.2. I am not sure if this is a related issue so did not want to start a new topic. 2 finger swipe to move the map Does not work either. It moves the map but snaps back to the original location on release. |
@necrotek Ah, thanks for mentioning that. I think that should be possible for me to reproduce, and if I can fix that then we can see if it also fixes the problems on macOS |
Alright, I can reproduce this also on my Mac Mini with an Intuos Wacom tablet. Will see if I can find an issue in the code. |
While reading the API, it was clear that we should use totalScaleFactor rather than scaleFactor since it was getting multiplied with the initial scaling factor. For some reason, scaleFactor must have been returning the totalScaleFactor in the past since the feature has been working fine at some point. I also noticed severe jittering of the view since it was getting repainted twice, right after changing the scale and then again after adjusting the scale origin. Fixed this by using AnchorUnderMouse, but kept the origin correction since AnchorUnderMouse appears to be off by one pixel per event, causing the view to shift slowly while pinching. Closes mapeditor#1305
in .15 I could pinch-to-zoom in OSX, but in .16 if I pinch at all it jumps to 1% zoom and can't be zoomed back. That would be a non-fatal bug, except the pinch gesture is often detected in OSX so the display is often unwantedly jumping to 1% zoom.
The text was updated successfully, but these errors were encountered: