Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support wms version in print spec #97

Closed
fvanderbiest opened this issue Dec 5, 2013 · 4 comments
Closed

support wms version in print spec #97

fvanderbiest opened this issue Dec 5, 2013 · 4 comments
Assignees

Comments

@fvanderbiest
Copy link

Currently, mapfishapp-print uses WMS version 1.1.1 to query the layers, see https://github.com/mapfish/mapfish-print/blob/master/src/main/java/org/mapfish/print/map/readers/WMSMapReader.java#L131

The French IGN's geoportail layers support WMS version 1.3.0 only, not 1.1.1
Thus, they are not printed.

@sbrunner
Copy link
Member

sbrunner commented Dec 9, 2013

Is it OK If when the version is specified in the 'customParams' we use the provided value ?

@fvanderbiest
Copy link
Author

probably, yes

@ghost ghost assigned sbrunner Dec 10, 2013
@fvanderbiest
Copy link
Author

I might change my mind. Indeed, the version parameter is part of the WMS layer's DEFAULT_PARAMS in OpenLayers.Layer.WMS prototype, see https://github.com/openlayers/openlayers/blob/master/lib/OpenLayers/Layer/WMS.js#L27

... which means that in GeoExt PrintProvider's WMS layer encoder, the version parameter won't go into the customParams, see https://github.com/geoext/geoext/blob/master/lib/GeoExt/data/PrintProvider.js#L651

As a result, I think it's better to have it alongside with the type = "WMS" parameter in the print spec.

@sbrunner
Copy link
Member

In booth case you should add the parameter then I don't see what it will change except to do it less generic ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants