Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apt new is broken #29

Closed
maphew opened this issue Mar 22, 2015 · 2 comments
Closed

apt new is broken #29

maphew opened this issue Mar 22, 2015 · 2 comments
Labels

Comments

@maphew
Copy link
Owner

maphew commented Mar 22, 2015

Package             Installed   Available
-----------------   ---------   ----------

TypeError: no_package() takes at least 2 arguments (0 given)
@maphew maphew added the bug label Mar 22, 2015
@amr66
Copy link
Contributor

amr66 commented Mar 23, 2015

i saw a call to no_package in get_version, no parameters used there!
def get_version(packagename):
if not dists[distname].has_key(packagename)
or not dists[distname][packagename].has_key(INSTALL):
no_package()
return (0, 0)
should be no_package(packagenane, distname), but aren't they global?

Dr. Andreas Müller -_- Universität Trier - FB VI - Kartographie, muellea@uni-trier.de
54286 Trier, Behringstr. 29, F 191, ++496512014576


Von: matt wilkie [notifications@github.com]
Gesendet: Sonntag, 22. März 2015 21:43
An: maphew/apt
Betreff: [apt] apt new is broken (#29)

Package Installed Available ----------------- --------- ---------- TypeError: no_package() takes at least 2 arguments (0 given)


Reply to this email directly or view it on GitHubhttps://github.com//issues/29.

@maphew
Copy link
Owner Author

maphew commented Mar 24, 2015

This reaches deep into the oldest code, well before my time, as well as solidly into some of my core changes. I made code easier to read and understand, but I made a fundamental mistake: version is now being read and reported straight from setup.ini dict and NOT from installed_db dict!

I have a fix queued for this to be committed shortly, but the logic error behind it is pernicious and is likely to cause troubles elsewhere, if it hasn't already. For example the archive file name and paths reported by get_info() and friends also generate their data from setup.ini and not from the actual local conditions. There needs to be a clear data model for local and remote.

@maphew maphew closed this as completed in b6d96bb Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants