-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example threejs terrain #3429
Example threejs terrain #3429
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3429 +/- ##
==========================================
- Coverage 75.60% 75.58% -0.02%
==========================================
Files 242 242
Lines 19199 19188 -11
Branches 4257 4254 -3
==========================================
- Hits 14515 14503 -12
- Misses 4684 4685 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good, I'm not familiar with three to fully understand this, but I think it's OK.
The three.js part itself looks good. There is a lot more math here than in the old debug page I posted in the issue thread, but I do not know enough about it to know if this is all needed. @MichaelLangbein, do you think you could you take a look at the old debug page and help us understand the differences? |
Sure thing, will do! I'll add some explaining comments some time after tonight. I can already say that there's not much change relative to the Debug-Page.
The whole rest of the matrix math stems from the existing example in the docs, but I'll add some comments there, too. |
I've just stumbled across this helpful discussion on issue 1318. |
Not sure I know how to answer this question, can you clarify it a bit? |
This is my understanding of how the variables in |
Alright, I've switched the code to use
|
Hmm, sometimes the unit tests don't seem to pass. I haven't changed anything about maplibre itself - is this an actual error or just a CI issue? |
Thanks for merging! I guess this also closes issue 3427. |
Thank you @MichaelLangbein! |
Launch Checklist
CHANGELOG.md
under the## main
section.Description
CustomLayer
together with maplibre's terrain.center
- even if the objects themselves are located at a point on the terrain that lies higher or lower thancenter
.sceneElevation - terrainCenterElevation
.Needs some review:
sceneElevation - terrainCenterElevation
approach suggested here really idiomatic?generate-images
as described here - is the provided image sufficient?