Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename projMatrix to modelViewProjectionMatrix #4215

Merged

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Jun 2, 2024

as mentioned in here, the projMatrix is actually a modelViewProjectionMatrix, and it unfortunately overloads and causes confusion about the otherwise well-defined term "projection matrix". This naming is a bit more explicit / strict, which i think we need to communicate clearly.

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.43%. Comparing base (b94fac4) to head (84d127e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4215      +/-   ##
==========================================
- Coverage   87.75%   87.43%   -0.33%     
==========================================
  Files         242      242              
  Lines       33081    33081              
  Branches     2332     2182     -150     
==========================================
- Hits        29030    28923     -107     
- Misses       3083     3149      +66     
- Partials      968     1009      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@birkskyum birkskyum requested review from HarelM June 2, 2024 14:38
@HarelM
Copy link
Collaborator

HarelM commented Jun 2, 2024

Do we consider this change a breaking change?
Please also add a changelog item.

@birkskyum
Copy link
Member Author

birkskyum commented Jun 3, 2024

Do we consider this change a breaking change? Please also add a changelog item.

I didn't consider it breaking of the public API (which is usually what we mean by breaking), since transform is internal and excluded from docs etc.

Added an entry to the changelog now.

CHANGELOG.md Outdated Show resolved Hide resolved
@HarelM HarelM merged commit d919ba3 into maplibre:main Jun 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants