-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline download crashes #177
Comments
The download function is a important feature for our App. Is there any update on this issue? |
A self-contained reproducer would help a lot in fixing this faster. Do you think you could prepare it? |
I can only reference to to flutter binding example: https://github.com/m0nac0/flutter-maplibre-gl/tree/main/example |
Sorry, I probably won't have enough time to try to reproduce this without flutter. |
DemoTiles is hosted on GitHub Pages and does not work with offline support. Please use another tile server to try out offline support. |
Any success on this issue, is it because of the DemoTiles? |
Hello @noorbakerally, I tried out offline support with the demo tiles which failed, while a 'normal' tile server worked. The problem I ran into was that it did not know how to handle a 304 'Not Modified' status code that GitHub Pages gave. I did not think it was worth investigating further because offline support for demo tiles does not make a lot of sense. So please try it out with another tile server, and if you run into any issues feel free to create an issue or a Q&A topic on GitHub Discussions. |
In the flutter bindings we are seeing this crash maplibre/flutter-maplibre-gl#39 when downloading e.g. regions from the source
https://demotiles.maplibre.org/style.json
in our test/example app.I suspect it has to do something with the new regex validations introduced here https://github.com/maplibre/maplibre-gl-native/blob/master/src/mbgl/util/mapbox.cpp as part of the migration to Maplibre. But I couldn't find any documentation for offline downloads.
Are there different requirements for source URLs for offline downloads compared to those for regular map displays?
The text was updated successfully, but these errors were encountered: