Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline download crashes #177

Closed
m0nac0 opened this issue Oct 25, 2021 · 7 comments
Closed

Offline download crashes #177

m0nac0 opened this issue Oct 25, 2021 · 7 comments

Comments

@m0nac0
Copy link
Contributor

m0nac0 commented Oct 25, 2021

In the flutter bindings we are seeing this crash maplibre/flutter-maplibre-gl#39 when downloading e.g. regions from the source https://demotiles.maplibre.org/style.json in our test/example app.

I suspect it has to do something with the new regex validations introduced here https://github.com/maplibre/maplibre-gl-native/blob/master/src/mbgl/util/mapbox.cpp as part of the migration to Maplibre. But I couldn't find any documentation for offline downloads.

Are there different requirements for source URLs for offline downloads compared to those for regular map displays?

@JanikoNaber
Copy link

The download function is a important feature for our App. Is there any update on this issue?

@ntadej
Copy link
Collaborator

ntadej commented Sep 14, 2022

A self-contained reproducer would help a lot in fixing this faster. Do you think you could prepare it?

@JanikoNaber
Copy link

JanikoNaber commented Sep 14, 2022

I can only reference to to flutter binding example: https://github.com/m0nac0/flutter-maplibre-gl/tree/main/example
Downloading a region results in a crash, see maplibre/flutter-maplibre-gl#39
But therefore you need flutter to be installed. @m0nac0 can you provide a reproducer without flutter?

@m0nac0
Copy link
Contributor Author

m0nac0 commented Sep 23, 2022

@m0nac0 can you provide a reproducer without flutter?

Sorry, I probably won't have enough time to try to reproduce this without flutter.

@louwers
Copy link
Collaborator

louwers commented Jan 25, 2023

DemoTiles is hosted on GitHub Pages and does not work with offline support. Please use another tile server to try out offline support.

@louwers louwers closed this as completed Jan 25, 2023
@noorbakerally
Copy link

Any success on this issue, is it because of the DemoTiles?

@louwers
Copy link
Collaborator

louwers commented Feb 7, 2023

Hello @noorbakerally, I tried out offline support with the demo tiles which failed, while a 'normal' tile server worked. The problem I ran into was that it did not know how to handle a 304 'Not Modified' status code that GitHub Pages gave.

I did not think it was worth investigating further because offline support for demo tiles does not make a lot of sense.

So please try it out with another tile server, and if you run into any issues feel free to create an issue or a Q&A topic on GitHub Discussions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants