Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files prefix changed from MGL to MLN #919

Merged

Conversation

alexcristici
Copy link
Collaborator

Prefix MGL was removed in favor of new prefix MLN.

@ntadej
Copy link
Collaborator

ntadej commented Mar 20, 2023

Why not only ML?

@louwers
Copy link
Collaborator

louwers commented Mar 20, 2023

Why not only ML?

Two letter Objective-C prefixes are reserved by Apple.

Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @alexcristici. Could you update the CHANGELOG.md for iOS?

We use it for the release notes.

@alexcristici
Copy link
Collaborator Author

Great stuff @alexcristici. Could you update the CHANGELOG.md for iOS?

We use it for the release notes.

@louwers Should I add it to the section Technical Improvements?

@louwers louwers added the iOS label Mar 20, 2023
@alexcristici
Copy link
Collaborator Author

Great stuff @alexcristici. Could you update the CHANGELOG.md for iOS?
We use it for the release notes.

@louwers Should I add it to the section Technical Improvements?

Done

@louwers
Copy link
Collaborator

louwers commented Mar 20, 2023

Sorry, it is a bit unclear but we have multiple changelogs in the repo.

@alexcristici the changelog for iOS is here: https://github.com/maplibre/maplibre-gl-native/blob/main/platform/ios/platform/ios/CHANGELOG.md

Could you also add

  • "(Breaking)" so we know that we should bump a major version on the next release
  • A mitigation guide (in this case, it's just "change all your MGL prefixes to MLN") + your comments on NSKeyedArchiver.

@alexcristici
Copy link
Collaborator Author

Sorry, it is a bit unclear but we have multiple changelogs in the repo.

@alexcristici the changelog for iOS is here: https://github.com/maplibre/maplibre-gl-native/blob/main/platform/ios/platform/ios/CHANGELOG.md

Could you also add

  • "(Breaking)" so we know that we should bump a major version on the next release
  • A mitigation guide (in this case, it's just "change all your MGL prefixes to MLN") + your comments on NSKeyedArchiver.

Please review now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants